On 2014-08-06 05:57:39 -0700, Diego Biurrun wrote: the commit message describes the commit only partially. It also uses gas-preprocessor.pl if it's available and not only on darwin. I think that's not going to work since the plain 'gas-preprocessor.pl' without options will produce mach-O specific code.
The idea is not bad though given that we need gas-preprocessor.pl on Linux with llvm's integrated assembler. > --- > configure | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/configure b/configure > index 45da142..81dfc09 100755 > --- a/configure > +++ b/configure > @@ -2199,8 +2199,6 @@ ranlib="ranlib" > strip="strip" > yasmexe="yasm" > > -nogas=":" > - > # machine > arch_default=$(uname -m) > cpu="generic" > @@ -3420,7 +3418,6 @@ case $target_os in > add_extralibs -lpoll -lgnugetopt > ;; > darwin) > - gas="gas-preprocessor.pl $cc" > enabled ppc && add_asflags -force_cpusubtype_ALL > SHFLAGS='-dynamiclib -Wl,-single_module > -Wl,-install_name,$(SHLIBDIR)/$(SLIBNAME_WITH_MAJOR),-current_version,$(LIBVERSION),-compatibility_version,$(LIBMAJOR)' > enabled x86_32 && append SHFLAGS -Wl,-read_only_relocs,suppress > @@ -3779,9 +3776,12 @@ EOF > } > > if enabled asm; then > + nogas=: > enabled_any arm aarch64 && nogas=die > enabled altivec && nogas=warn > > + check_cmd gas-preprocessor.pl && gas="gas-preprocessor.pl $cc" I think it should use $as instead of $cc, if $as is not overriden via configure command line it's the same anyway. if someone want's to use another assembler it should also be after gas-preprocessor. Janne _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
