On Sep 17, 2014 9:42 PM, "Luca Barbato" <lu_z...@gentoo.org> wrote:
>
> On 18/09/14 06:35, Reinhard Tartler wrote:
> > - /* select format : favour native format */
> > +#define CHECK_IOCTL_ERROR(event)
\
> > + if (err < 0) {
\
> > + av_log(s1, AV_LOG_ERROR, #event ": %s\n", strerror(errno));
\
>
> strerror should not be used.
Is there a reason not to use strerror()? I'm using it because the original
code was using it.
>
> > + goto fail;
\
> > + }
> > +
> > + /* select format : favour native format
> > + * We don't CHECK_IOCTL_ERROR here because even if failed OSS
still may be
> > + * usable. If OSS is not usable the SNDCTL_DSP_SETFMTS later is
going to
> > + * fail anyway. `err =` kept to eliminate compiler warning. */
> > err = ioctl(audio_fd, SNDCTL_DSP_GETFMTS, &tmp);
>
> (void) cast should do the same.
Why didn't I think of that?
Luca and Reinhard, thanks for taking a look at this. Sorry about forgetting
to send this patch to libav-devel in the first place.
[...]
Timothy
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
