On 14/10/14 03:01, Timothy B. Terriberry wrote:
I don't use pulseaudio, so I can't test the exact conditions that led to bug 753, but basic conversion from Vorbis to Opus fails for me without the attached patch (producing an initial page with a granule position 1 too small to be valid), so this is at least a step in the right direction.
I had a look at the patch and doesn't seem wrong, that reminds me that there is a patch from me pending since this summer (I hadn't time to regenerate properly the references and put in rsync to push it).
I also notice that the flag AVFMT_TS_NEGATIVE is set for all muxer classes in libavformat/oggenc.c, but I don't believe this is actually true for any of them (the granule position value -1 is reserved as invalid, but granule positions are otherwise treated as unsigned, leaving no way to represent a negative timestamp). I didn't change anything there, however, as I don't really understand all the implications, and I don't want to paper over other problems like this one.
Probably should be removed from there. Thanks a lot! lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
