On Mon, Oct 27, 2014 at 4:13 PM, Marc-Antoine ARNAUD <arnaud.marcanto...@gmail.com> wrote: > Hi Vittorio, > > Yeah I'm agreed with your's patches to setup field_order parameter context. > But after doing that, it require to setup this information from the > field_order to he output stream. > And it's the reason of the patch to set the interlaced mode (TT or BB) in > the Mpeg2 codec header correctly.
Ok, I see. The issue is that as Hendrik said interlacing is more a frame-property so it's management can be tricky. The best is a user-set command line in my opinion. Also interlacing is bad and should not be used ;) > Or maybe if I understand your proposition is to set the top_filed_first > parameter in the avcodec_encode_video2 function to be more generic ? Yes that too, it needs to be generic since mpeg2 is not the only encoder being affected by this. Vittorio > > 2014-10-27 16:42 GMT+01:00 Vittorio Giovara <vittorio.giov...@gmail.com>: > >> On Mon, Oct 27, 2014 at 9:50 AM, Marc-Antoine ARNAUD >> <arnaud.marcanto...@gmail.com> wrote: >> > Someone can give a feedback on this patch ? >> > Thanks. >> > >> > Marc-Antoine >> >> If I get the problem correctly, the codec should take the interlaced >> state of the container and correctly mark its frames as such. >> Unfortunately this problem is not isolated to mpeg2, but rather all >> encoders are affected. >> The RightWay to fix this in my opinion would be to introduce a command >> line parameter and have contextes correctly initialized. I looked at >> it in the past, check out these two commits for what I mean >> >> >> https://github.com/kodabb/libav/commit/a0ef5fbfe1d5bc733060ee4bf004ea5439e5f351 >> >> https://github.com/kodabb/libav/commit/55998e94cbec80a71ff0b4f58f21db02d1da2ea6 >> >> -- >> Vittorio >> _______________________________________________ >> libav-devel mailing list >> libav-devel@libav.org >> https://lists.libav.org/mailman/listinfo/libav-devel >> > > > > -- > *Marc-Antoine* > |e:arnaud.marcanto...@gmail.com > |tel: 06-84-71-84-45 > | ohloh: http://bit.ly/1iwtlsU > [image: LinkedIn] > <http://s.wisestamp.com/links?url=https%3A%2F%2Fwww.linkedin.com%2Fpub%2Fmarc-antoine-arnaud%2Fb%2F7b8%2F2a3&sn=YXJuYXVkLm1hcmNhbnRvaW5lQGdtYWlsLmNvbQ%3D%3D> > [image: > Google Plus] > _______________________________________________ > libav-devel mailing list > libav-devel@libav.org > https://lists.libav.org/mailman/listinfo/libav-devel -- Vittorio _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
