On 10/11/14 22:42, Kieran Kunhya wrote:
> ---
>  libavfilter/vf_interlace.c          | 55 ++++++++++++-------------
>  libavfilter/x86/Makefile            |  2 +
>  libavfilter/x86/vf_interlace.asm    | 80 
> +++++++++++++++++++++++++++++++++++++
>  libavfilter/x86/vf_interlace_init.c | 42 +++++++++++++++++++
>  4 files changed, 150 insertions(+), 29 deletions(-)
>  create mode 100644 libavfilter/x86/vf_interlace.asm
>  create mode 100644 libavfilter/x86/vf_interlace_init.c
> 
> diff --git a/libavfilter/vf_interlace.c b/libavfilter/vf_interlace.c
> index c534b0b..697daa7 100644
> --- a/libavfilter/vf_interlace.c
> +++ b/libavfilter/vf_interlace.c
> @@ -30,24 +30,7 @@
>  #include "avfilter.h"
>  #include "internal.h"
>  #include "video.h"
> -
> -enum ScanMode {
> -    MODE_TFF = 0,
> -    MODE_BFF = 1,
> -};
> -
> -enum FieldType {
> -    FIELD_UPPER = 0,
> -    FIELD_LOWER = 1,
> -};
> -
> -typedef struct InterlaceContext {
> -    const AVClass *class;
> -    enum ScanMode scan;    // top or bottom field first scanning
> -    int lowpass;           // enable or disable low pass filterning
> -    AVFrame *cur, *next;   // the two frames from which the new one is 
> obtained
> -    int got_output;        // signal an output frame is reday to 
> request_frame()
> -} InterlaceContext;
> +#include "vf_interlace.h"

It is missing, name it interlace.h if you don't mind.

> +    if (s->lowpass){
                      ^
> +        s->lowpass_line = lowpass_line_c;
> +        if(ARCH_X86)
             ^
> +            ff_interlace_init_x86(s);
> +    }

some spaces might be nice, while at it.

Beside that, looks good.

lu
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to