On 21/11/14 13:01, Vittorio Giovara wrote:
> On Fri, Nov 14, 2014 at 11:09 AM, Luca Barbato <lu_z...@gentoo.org> wrote:
>> On 12/11/14 19:10, Vittorio Giovara wrote:
>>> CC: libav-sta...@libav.org
>>> Bug-Id: CID 700555
>>> ---
>>>  libavcodec/qdm2.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libavcodec/qdm2.c b/libavcodec/qdm2.c
>>> index 94bda91..4718b34 100644
>>> --- a/libavcodec/qdm2.c
>>> +++ b/libavcodec/qdm2.c
>>> @@ -730,7 +730,7 @@ static void fill_coding_method_array(sb_int8_array 
>>> tone_level_idx,
>>>                      for (j = 0; j < 64; j++)
>>>                          acc += tone_level_idx_temp[ch][sb][j];
>>>
>>> -            multres = 0x66666667 * (acc * 10);
>>> +            multres = 0x66666667LL * (acc * 10);
>>>              esp_40 = (multres >> 32) / 8 + ((multres & 0xffffffff) >> 31);
>>>              for (ch = 0;  ch < nb_channels; ch++)
>>>                  for (sb = 0; sb < 30; sb++)
>>>
>>
>> How big acc could be?
> 
> I think it does not matter? 0x66666667 * 10 already overflows on a 32
> bit variable.
> 

Ok then.
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to