On Mon, Nov 24, 2014 at 3:22 PM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 24/11/14 14:49, Hendrik Leppkes wrote: >> >> On Sun, Nov 23, 2014 at 10:52 PM, Luca Barbato <lu_z...@gentoo.org> wrote: >> >>> On 20/11/14 16:41, Vittorio Giovara wrote: >>> >>>> And with the power of git am and sed, here is the updated set, with >>>> small >>>> cosmetic fixes here and there. I reorder the set in three "chapters", >>>> and >>>> I'd not mind to squash the cosmetics in a single one. >>>> >>>> Vittorio >>>> >>>> >>> If there isn't any other comment I'd merge the set. >>> >>> >> After some discussion on IRC today it occured to me that this set is >> flawed. >> >> AVCodecParser.parser_parse is not allowed to return error codes, as the >> API >> does not allow that. Both positive and negative values are already used as >> normal return values for valid data. >> This mostly affects all the ENOMEM cases where you return an error code >> now, but the code that actually calls this is not capable of handling >> error >> codes. >> > > You are right, I'll try to fix that part before this set.
Maybe we should wait for the new parser api to appear before applying further changes. I'll hold on the fixes I sent too. -- Vittorio _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
