On 16/12/14 3:05 PM, Vittorio Giovara wrote: > On Tue, Dec 16, 2014 at 6:10 PM, James Almer <jamr...@gmail.com> wrote: >> On 16/12/14 11:58 AM, Vittorio Giovara wrote: >>> From: James Almer <jamr...@gmail.com> >>> >>> Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> >>> --- >>> Dropped the sign-offs since the file was modified. >>> Addressed Anton's and James' comment. >>> Vittorio >>> >>> Changelog | 1 + >>> libavformat/Makefile | 1 + >>> libavformat/oggdec.c | 1 + >>> libavformat/oggdec.h | 1 + >>> libavformat/oggparsevp8.c | 142 >>> ++++++++++++++++++++++++++++++++++++++++++++++ >>> libavformat/version.h | 4 +- >>> 6 files changed, 148 insertions(+), 2 deletions(-) >>> create mode 100644 libavformat/oggparsevp8.c >> >> Please undo the change Anton requested. It was correct in the first patch. >> Check the samples from http://people.freedesktop.org/~slomo/ogg-vp8/ and see >> the framerate it reports for them. > > Thanks for the link. According to the specifications hosted there > http://people.freedesktop.org/~slomo/ogg-vp8/ogg-vp8.pdf it looks like > numerator and denominator are parsed wrong. > > your code > st->codec->width = AV_RB16(p + 8); > st->codec->height = AV_RB16(p + 10); > st->sample_aspect_ratio.num = AV_RB24(p + 12); > st->sample_aspect_ratio.den = AV_RB24(p + 15); > framerate.den = AV_RB32(p + 18); > framerate.num = AV_RB32(p + 22); > > spec code > FW 16 Stored frame width. > FH 16 Stored frame height. > PARN 24 Pixel aspect ratio numerator. > PARD 24 Pixel aspect ratio denominator. > FPSN 32 Frame rate numerator. > FPSD 32 Frame rate denominator > > So it looks like the change Anton requested was correct and the > AV_RB32 need to be inverted, unless I am missing something. James, can > you confirm for me please?
Yes, that should work as well. > > On an unrelated note, would it be possible to have a fate test? > Thanks Sure, I'll send one after this is committed. _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
