Re: [libav-devel] [PATCH 2/3] libavcodec: Add an OpenH264 encoder wrapper

[Derek Buitenhuis]

On 12/31/2014 3:21 PM, Martin Storsjö wrote:
> +    param.bEnableBackgroundDetection = 1;
> +    param.bEnableAdaptiveQuant       = 1;

Is there no equivalent of param_parse()? Seems like hardcoding
all these vals is a bit weird.

> +    if (avctx->thread_count != 1) {
> +        SSliceConfig *cfg = &param.sSpatialLayers[0].sSliceCfg;
> +
> +        param.iMultipleThreadIdc = avctx->thread_count;
> +
> +        cfg->uiSliceMode = s->slice_mode;
> +        cfg->sSliceArgument.uiSliceNum = avctx->slice_count;
> +    }


Does this also handle thread_count == 0, since I see CODEC_CAP_AUTO_THREADS
is set?

It might be possible to just drop the if() surrounding it, no? i.e. we should
respect slice_count regardless.

- Derek
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel