On 07 Jan, Luca Barbato wrote :
> On 07/01/15 12:43, Jean-Baptiste Kempf wrote:
> >On 07 Jan, Luca Barbato wrote :
> >>The bound check should be updated (otherwise you can craft evil
> >>packets that read over the buffer).
> >
> >Sure.
> >
> >>Having branches in loops isn't that nice.
> >
> >Tbh, I don't see the point.
> >For me the code is less readable with this split.
> 
> "if it does not have alpha make all entries beside the first opaque,
> otherwise read the alpha values for each of them"
> 
> vs
> 
> "for each entry if it has alpha read the value, otherwise make it opaque,
> but only if the index entry is different from 0, in that case set it
> transparent"

Not my project. I do not care.


-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to