On Thu, 15 Jan 2015, Vittorio Giovara wrote:

On Thu, Jan 15, 2015 at 3:24 PM, Martin Storsjö <[email protected]> wrote:

Ok - I'm not familiar enough to comment much on the swscale internals, but
this makes the output consistent on bigendian, and actually makes at least a
fully opaque alpha plane stay that way after scaling, so ok as far as I can
see.

Karma points for scaling a picture with actual alpha (not just 255 for all
pixels) and checking that it turns out right after scaling.

Yes I did test with a real alpha image :)

Updating the changelog to explain more what has been changed

   swscale: fix gbrap to gbrap alpha scaling

   Casting and shifting to uint16_t was incorrect, instead use the value
   from the alpha plane directly.

Somehow I didn't see this improved commit message in the commit that actually was pushed - where did the improved message go?

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to