On Mon, Feb 02, 2015 at 11:49:26AM +0100, Peter Meerwald wrote: > Signed-off-by: Peter Meerwald <[email protected]> > > --- > > v2: > license statement in g722dsp.c (Timothy)
Not quite, you copy and pasted only part of the standard license header. > --- a/libavcodec/g722dec.c > +++ b/libavcodec/g722dec.c > @@ -122,7 +124,7 @@ static int g722_decode_frame(AVCodecContext *avctx, void > *data, > > c->prev_samples[c->prev_samples_pos++] = rlow + rhigh; > c->prev_samples[c->prev_samples_pos++] = rlow - rhigh; > - ff_g722_apply_qmf(c->prev_samples + c->prev_samples_pos - 24, > + c->dsp.apply_qmf(c->prev_samples + c->prev_samples_pos - 24, > &xout1, &xout2); Indentation is now off on the second line. > --- /dev/null > +++ b/libavcodec/g722dsp.c > @@ -0,0 +1,44 @@ > +/* > + * Copyright (c) 2015 Peter Meerwald <[email protected]> > + * Based on code previously in g722.c No need for this remark. > + * This file is part of Libav. > + * > + * Libav is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * Libav is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + */ see above > +void ff_g722dsp_init(struct G722DSPContext *c) Here you use the struct name. Add av_cold to the init function declaration, see how it's done in other *dsp.c files. > --- /dev/null > +++ b/libavcodec/g722dsp.h > @@ -0,0 +1,32 @@ > +void ff_g722dsp_init(G722DSPContext *c); Here you use the typedeffed name. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
