On Thu, Feb 19, 2015 at 10:16:29PM -0500, Vittorio Giovara wrote:
> --- /dev/null
> +++ b/libavcodec/hqx.c
> @@ -0,0 +1,632 @@
> +static inline void put_blocks(AVFrame *pic, int plane,
> + int x, int y, int ilace,
> + int16_t *block0, int16_t *block1,
> + const uint8_t *quant)
> +{
> + hqx_idct_put(
> + (uint16_t *)(pic->data[plane] + x * 2 + y * pic->linesize[plane]),
> + pic->linesize[plane] * fields, block0, quant);
> + hqx_idct_put(
> + (uint16_t *)(pic->data[plane] + x * 2 + y * pic->linesize[plane]),
> + pic->linesize[plane] * fields, block1, quant);
IMO an ugly way to break lines...
> --- /dev/null
> +++ b/libavcodec/hqx.h
> @@ -0,0 +1,63 @@
> +
> +#ifndef AVCODEC_HQXVLC_H
> +#define AVCODEC_HQXVLC_H
Filename and guard name don't match.
> +#include "get_bits.h"
This header does not seem to need get_bits.h, but many other headers.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
