On Tue, Mar 03, 2015 at 12:15:43AM +0100, Thomas Volkert wrote:
> --- /dev/null
> +++ b/libavformat/rtpdec_vp9.c
> @@ -0,0 +1,298 @@
> +static av_cold int vp9_init(AVFormatContext *ctx, int st_index,
> +                             PayloadContext *data)
> +{
> +    av_dlog(ctx, "vp9_init() for stream %d\n", st_index);

This av_dlog seems pretty pointless in production code.

> +static int vp9_handle_packet(AVFormatContext *ctx, PayloadContext 
> *rtp_vp9_ctx,
> +                             AVStream *st, AVPacket *pkt, uint32_t 
> *timestamp,
> +                             const uint8_t *buf, int len, uint16_t seq,
> +                             int flags)
> +{
> +    /* drop data of previous packets in case of non-continuous (lossy) 
> packet stream */
> +    if (rtp_vp9_ctx->buf && rtp_vp9_ctx->timestamp != *timestamp) {
> +        ffio_free_dyn_buf(&rtp_vp9_ctx->buf);
> +    }

unnecessary {}

> +    if (has_layer_idc) {
> +        if (len < 1) {
> +            av_log(ctx, AV_LOG_ERROR, "Too short RTP/VP9 packet");

missing \n

> +    if (has_ref_idc) {
> +        while (ref_fields) {
> +            if (len < 1) {
> +                av_log(ctx, AV_LOG_ERROR, "Too short RTP/VP9 packet\n");

same

> +            if (has_ref_field_ext_pic_id) {
> +                if (len < 2) {
> +                    av_log(ctx, AV_LOG_ERROR, "Too short RTP/VP9 packet\n");

again

> +    if (has_ss_data) {
> +        avpriv_report_missing_feature(ctx, "VP9 scalability structure 
> data\n");

extra \n

> +    if (has_su_data) {
> +        avpriv_report_missing_feature(ctx, "VP9 scalability update structure 
> data\n");

ditto

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to