On Tue, Mar 31, 2015 at 07:03:33PM +0200, Vittorio Giovara wrote:
> --- /dev/null
> +++ b/libavcodec/hq_hqa.c
> @@ -0,0 +1,378 @@
> +static int hq_hqa_decode_frame(AVCodecContext *avctx, void *data,
> + int *got_frame, AVPacket *avpkt)
> +{
> + /* Parse FIEL tag. */
> + field_order = AV_RL32(src + 48);
> + switch(field_order) {
space after switch
> + case 0: avctx->field_order = AV_FIELD_TT; break;
> + case 1: avctx->field_order = AV_FIELD_BB; break;
> + case 2: avctx->field_order = AV_FIELD_PROGRESSIVE; break;
I'd break lines here.
> --- /dev/null
> +++ b/libavcodec/hq_hqadata.c
> @@ -0,0 +1,8376 @@
> +/* tables section - one per supported profile */
> +static const uint8_t hq_tab_01[] = {
> + 0, 0, 12, 3, 20, 0, 28, 3, 40, 0, 0, 10, 15, 6, 20,
> + 10, 35, 6, 40, 10, 7, 13, 15, 16, 23, 13, 35, 16, 39, 13,
Indentation is off on the first line.
> --- /dev/null
> +++ b/libavcodec/hq_hqadsp.c
> @@ -0,0 +1,130 @@
> +static void hq_idct_put_c(uint8_t *dst, int stride, int16_t *block)
> +
> +av_cold void ff_hqdsp_init(HQDSPContext *c)
> +{
> + c->idct_put = hq_idct_put_c;
I'd drop the _c suffix, it's pointless.
> --- /dev/null
> +++ b/libavcodec/hq_hqadsp.h
> @@ -0,0 +1,38 @@
> +
> +/**
> + * @file
> + * HQ/HQA variant of AAN IDCT
> + * It differs from the standard aan idct in precision and in the second
> stage.
AAN IDCT
No further comments from me..
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
