On Mon, Apr 27, 2015 at 07:13:25PM +0100, Vittorio Giovara wrote:
> They are just duplicates of AVCodecContext members so use them directly.
They are just duplicates of AVCodecContext members so use those instead.
> --- a/libavcodec/ituh263enc.c
> +++ b/libavcodec/ituh263enc.c
> @@ -459,7 +459,7 @@ void ff_h263_encode_mb(MpegEncContext * s,
> int16_t pred_dc;
> int16_t rec_intradc[6];
> int16_t *dc_ptr[6];
> - const int interleaved_stats= (s->flags&CODEC_FLAG_PASS1);
> + const int interleaved_stats = (s->avctx->flags & CODEC_FLAG_PASS1);
nit: drop pointless ()
> --- a/libavcodec/mpegvideo.c
> +++ b/libavcodec/mpegvideo.c
> @@ -2158,7 +2155,9 @@ FF_ENABLE_DEPRECATION_WARNINGS
>
> - if ((s->flags&CODEC_FLAG_PSNR) || !(s->encoding && (s->intra_only ||
> s->pict_type==AV_PICTURE_TYPE_B) && s->avctx->mb_decision !=
> FF_MB_DECISION_RD)) { //FIXME precalc
> + if ((s->avctx->flags & CODEC_FLAG_PSNR) ||
> + !(s->encoding && (s->intra_only || s->pict_type==AV_PICTURE_TYPE_B)
> &&
> + s->avctx->mb_decision != FF_MB_DECISION_RD)) { //FIXME precalc
nit: spaces around == and after //
> --- a/libavcodec/mpegvideo_enc.c
> +++ b/libavcodec/mpegvideo_enc.c
> @@ -3396,7 +3394,9 @@ static int encode_picture(MpegEncContext *s, int
> picture_number)
>
> - if(s->qscale < 3 && s->max_qcoeff<=128 &&
> s->pict_type==AV_PICTURE_TYPE_I && !(s->flags & CODEC_FLAG_QSCALE))
> + if (s->qscale < 3 && s->max_qcoeff<=128 &&
> + s->pict_type==AV_PICTURE_TYPE_I &&
> + !(s->avctx->flags & CODEC_FLAG_QSCALE))
> s->qscale= 3; //reduce clipping problems
nit: spaces around ==
OK
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
