On Tue, May 26, 2015 at 4:17 AM, James Almer <jamr...@gmail.com> wrote:
> On 25/05/15 2:31 AM, Steve Lhomme wrote:
>> On Sun, May 24, 2015 at 1:13 PM, Luca Barbato <lu_z...@gentoo.org> wrote:
>>> On 24/05/15 07:59, Steve Lhomme wrote:
>>>> Any update on this patch ?
>>>>
>>>
>>> If it works for you I'll merge it Monday. I do not have mean to test it
>>> directly I guess.
>>
>> Yes, it works. Building may be tricky until my patches are merged into
>> wine & mingw-w64, unless you build with the Microsoft SDK.
>
> In addition to the mingw-w64 breakage i mentioned in another thread, this is
> making the h264, hevc and other fate tests fail on msvc x86_32.
>
> https://fate.libav.org/x86_32-msvc11-windows-native/20150525152900
> https://fate.libav.org/x86_32-msvc12-windows-native/20150525155646
>
> msvc x86_64 seems unaffected.


It may not like such macros outputting 2 incompatible types of pointers.

#define DXVA_CONTEXT_DECODER(avctx, ctx) (avctx->pix_fmt ==
AV_PIX_FMT_D3D11VA_VLD ? ctx->d3d11va.decoder : ctx->dxva2.decoder)

Another possibility could be to define the 2 pointers in the functions
and use the right one accordingly (all via macros).

Or do the d3d11va/dxva2 test at each call like it's done in the shared
dxva2.c and only keep the D3D11VA_CONTEXT() and DXVA2_CONTEXT()
macros.
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to