On 31/05/15 22:40, Hendrik Leppkes wrote: > On Sun, May 31, 2015 at 10:28 PM, Vittorio Giovara > <[email protected]> wrote: >> On Sun, May 31, 2015 at 4:47 PM, Luca Barbato <[email protected]> wrote: >>> --- >>> >>> Tested with the vpx patchset. >>> >>> configure | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/configure b/configure >>> index 936c389..91edd43 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -960,8 +960,8 @@ check_pkg_config(){ >>> pkg_cflags=$($pkg_config --cflags $pkg_config_flags $pkg) >>> pkg_libs=$($pkg_config --libs $pkg_config_flags $pkg) >>> check_func_headers "$headers" "$funcs" $pkg_cflags $pkg_libs "$@" && >>> - set_safe ${pkg}_cflags $pkg_cflags && >>> - set_safe ${pkg}_libs $pkg_libs >>> + set_safe "${pkg}_cflags" $pkg_cflags && >>> + set_safe "${pkg}_libs" $pkg_libs >>> } >>> >>> check_exec(){ >>> @@ -1057,8 +1057,8 @@ require2(){ >>> require_pkg_config(){ >>> pkg="$1" >>> check_pkg_config "$@" || die "ERROR: $pkg not found" >>> - add_cflags $(get_safe ${pkg}_cflags) >>> - add_extralibs $(get_safe ${pkg}_libs) >>> + add_cflags $(get_safe "${pkg}_cflags") >>> + add_extralibs $(get_safe "${pkg}_libs") >>> } >>> >>> hostcc_e(){ >>> -- >> >> Maybe add a description like "this makes sure that conditions with >> spaces are expanded correctly" >> Otherwise ok > > Maybe that should be the proper commit message? > I had to somewhat assume that this is what its trying to fix, but the > change itself has nothing in it for versions or whatnot.
"configure: Support the extended pkgconf syntax Make possible to require a combination of packages and/or pin specific versions." Is enough? You can have "foo >= 1.2.3 bar <= 0.5" and such. lu > _______________________________________________ > libav-devel mailing list > [email protected] > https://lists.libav.org/mailman/listinfo/libav-devel > _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
