On Fri, 10 Jul 2015, Anton Khirnov wrote:

Quoting Martin Storsjö (2015-07-09 22:14:25)
From: Dan Flett <[email protected]>

Tested on a Raspberry Pi.
---
 libavdevice/fbdev.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/libavdevice/fbdev.c b/libavdevice/fbdev.c
index 27e2ed3..f079e4e 100644
--- a/libavdevice/fbdev.c
+++ b/libavdevice/fbdev.c
@@ -58,6 +58,7 @@ static struct rgb_pixfmt_map_entry rgb_pixfmt_map[] = {
     {  32,       3,           2,           8,            0,   AV_PIX_FMT_ABGR  
},
     {  24,       0,           8,          16,            0,   AV_PIX_FMT_RGB24 
},
     {  24,      16,           8,           0,            0,   AV_PIX_FMT_BGR24 
},
+    {  16,      11,           5,           0,           16,   
AV_PIX_FMT_RGB565 },

I wonder why is the alpha_offset non-zero when the format does not have
alpha. Though looking at the code, alpha_offset is not used anywhere so
maybe it doesn't matter at all.

Indeed - it shouldn't matter, but to be consistent with rgb24/bgr24, it should probably be set to 0 instead.

Will push with that changed.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to