On Tue, 21 Jul 2015, Hendrik Leppkes wrote:

On Tue, Jul 21, 2015 at 3:07 PM, Steve Lhomme <rob...@gmail.com> wrote:
On Tue, Jul 21, 2015 at 2:52 PM, Hendrik Leppkes <h.lepp...@gmail.com> wrote:
On Tue, Jul 21, 2015 at 2:07 PM, Steve Lhomme <rob...@gmail.com> wrote:
so no environment hack is needed when calling --toolchain=msvc
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 16bf852..5afaaa6 100755
--- a/configure
+++ b/configure
@@ -2633,7 +2633,7 @@ case "$toolchain" in
         else
             cc_default="c99wrap cl"
         fi
-        ld_default="link"
+        ld_default=`cygpath -d "\`which cl.exe | sed "s/cl.exe/link.exe/g"\`"`
         nm_default="dumpbin -symbols"
         ar_default="lib"
         target_os_default="win32"
--

$ cygpath
sh: cygpath: command not found

Personally I feel like having an environment where link.exe in path is
not the msvc link.exe is a wrongly-setup environment anyway.
I've never had the problem, and i can't say i had to actively "hack"
anything. Just use one of the msvc bat files to setup the env (which
ship with msvc), and then use sh.exe to go into a msys shell.

I had the issues described here:
http://www.ffmpeg.org/platform.html#Microsoft-Visual-C_002b_002b-or-Intel-C_002b_002b-Compiler-for-Windows

Having msys2 as requirement should bring this issue many times. Also
since msys2 is a requirement, I'm surprised you don't have cygpath.

msys2 is not a requirement, its just the documented/suggested way to
go, since its easier to setup.
msys(1) setups work perfectly fine, and breaking them over this is
something I would veto.

+1; recommend whatever, but don't needlessly break working envs, especially for a cornercase like this, where the new solution is really unclean anyway.

// Martin
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to