On Sun, 26 Jul 2015, Martin Storsjö wrote:

On Sun, 26 Jul 2015, Jean-Baptiste Kempf wrote:

On 26 Jul, Martin Storsjö wrote :
---
 configure | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index 446a786..77eb8f5 100755
--- a/configure
+++ b/configure
@@ -4007,6 +4007,7 @@ elif enabled alpha; then

 elif enabled arm; then

+ enabled msvc && check_cpp_condition stddef.h "_M_ARM >= 7" && enable thumb
     check_cpp_condition stddef.h "defined __thumb__" && enable_weak thumb
     enabled thumb && check_cflags -mthumb || check_cflags -marm

Doesn't that break Windows CE?

Ooh, we have a reviewer that actually pays attention!

_M_ARM indicates the arm instruction set version targeted, so we only do this for armv7 or newer. The old VC compilers for Windows CE target armv4, so they have _M_ARM == 4.

We could also check _M_ARMT which indicates whether we're building for thumb. That'd probably be even more correct here I guess.

If you ever cared about that...

In theory at least - we still have a mingw32ce fate instance, but I haven't tried running such code on an actual device for many years.

The latest MSVC version (at least the normal, public ones I've seen) that had ARM compilers for CE was 2008, and that one defaulted to armv4, until they went absent and returned with windows phone 8, for armv7.

Also, just for reference, libav doesn't build with the official CE (or windows mobile) SDKs - it's missing way too much stuff, that mingw32ce fills in. (And even then, the mingw32ce headers need to be patched for libav to be buildable.)

// Martin
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to