On 28/07/15 19:07, Martin Storsjö wrote:
> Umm, no.
> 
> What happens if one of the options isn't found? av_opt_get will return
> an error, and the HLS demuxer will refuse to work, even though things
> are just fine. Keep in mind that the HLS demuxer works with any input
> protocol, not only http. (E.g. you can play back an m3u8 and associated
> ts files over file:// just fine.)
> 
> Ideally, save_avio_options should continue even if one of the options
> isn't found. Consider if the AVIOContext is some other protocol that
> e.g. does have the field "headers" but not "user_agent" (or vice versa),
> then it still makes sense to continue, and store the fields that exist,
> even if not all of them do.

Ok, it would make simpler to factorize that.

I cannot use a single dictionary since the options would be consumed
every time it is passed so I went the simpler way.

lu
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to