On Mon, Sep 7, 2015 at 12:59 PM, Niels Möller <ni...@lysator.liu.se> wrote: > Vittorio Giovara <vittorio.giov...@gmail.com> writes: > >> if (desc->flags & AV_PIX_FMT_FLAG_GRAY) >> >> is much simpler, more concise, and more correct than >> >> if ((desc->nb_components == 1 || (desc->nb_components == 2 && >> desc->flags & AV_PIX_FMT_FLAG_ALPHA) && !(desc->flags & >> AV_PIX_FMT_FLAG_RGB)) >> >> don't you think? ^_* > > Sure, but AV_PIX_FMT_IS_GRAY(desc) would be concise too. One can have > redundant interfaces with extra sugar, without putting redundant data in > the data structures. >
I agree. PS: RGB is 3 components, even if packed. It doesn't count planes, but actual components. - Hendrik _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
