On 9/23/2015 2:11 PM, Martin Storsjö wrote:
> On Wed, 23 Sep 2015, Derek Buitenhuis wrote:
> 
>> There's no reason this should be required.
>>
>> Signed-off-by: Derek Buitenhuis <[email protected]>
>> ---
>> As far as I know, anyway.
>> ---
>> libavformat/movenc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
>> index ee2f089..90857e3 100644
>> --- a/libavformat/movenc.c
>> +++ b/libavformat/movenc.c
>> @@ -2977,7 +2977,7 @@ static int mov_write_ftyp_tag(AVIOContext *pb, 
>> AVFormatContext *s)
>>     else if (mov->mode == MODE_MP4)
>>         ffio_wfourcc(pb, "mp41");
>>
>> -    if (mov->flags & FF_MOV_FLAG_DASH && mov->flags & 
>> FF_MOV_FLAG_GLOBAL_SIDX)
>> +    if (mov->flags & FF_MOV_FLAG_DASH)
>>         ffio_wfourcc(pb, "dash");
>>
>>     return update_size(pb, pos);
>> -- 
>> 1.8.3.1
> 
> Ok with me. (The original cause of this code is that I originally tried to 
> mimic different files for different usecases produced by other software, 
> and the m4s init segments I looked at lacked this brand. But I do agree 
> that it probably should be added.)
>

Seems I was wrong:

[14:13] < Daemon404> muken, ping
[14:13] < Daemon404> any comment ?
[14:36] < muken> Daemon404: you're wrong since dash brand means Indexed 
self-initialized media segment
[14:36] < Daemon404> this is why i asked you
[14:36] < Daemon404> i am often wrong.

- Derek
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to