On 21/10/15 11:05, Martin Storsjö wrote:
> Some RTSP servers ("HiIpcam/V100R003 VodServer/1.0.0") respond to
> our keepalive GET_PARAMETER request by a truncated RTSP header
> (lacking the final empty line to indicate a complete response
> header). Prior to 764ec70149, this worked just fine since we
> reacted to the $ as interleaved packet indicator anywhere.
>
> Since $ is a valid character within the response header lines,
> 764ec70149 changed it to be ignored there. But to keep
> compatibility with such broken servers, we need to at least
> allow reacting to it at the start of lines.
> ---
> I think doing this should be pretty safe; no valid RTSP response
> (nor request) header line should start with a $ as far as I know.
> (It is valid within the actual content of the header lines though.)
>
> Unrelatedly, we could also skip sending the keepalive requests
> completely when using tcp as transport method. That would avoid
> this issue, but wouldn't be a complete fix in itself.
>
> This fixes playback of -rtsp_transport tcp rtsp://176.106.65.249:555/12
> (which currently breaks once the first keepalive message is sent),
> broken since 764ec70149.
> ---
> libavformat/rtsp.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Ok.
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
