On Thu, Oct 22, 2015 at 6:06 PM, Luca Barbato <lu_z...@gentoo.org> wrote:
> On 22/10/15 15:11, Vittorio Giovara wrote:
>> On Sat, Oct 10, 2015 at 2:44 PM, Luca Barbato <lu_z...@gentoo.org> wrote:
>>> From: Arttu Ylä-Outinen <arttu.yla-outi...@tut.fi>
>>>
>>> Signed-off-by: Arttu Ylä-Outinen <arttu.yla-outi...@tut.fi>
>>> Signed-off-by: Luca Barbato <lu_z...@gentoo.org>
>>> ---
>>>
>>> Arttu kindly updated it, as an experimental codec probably it is mainly
>>> fine,
>>> from my testing I noticed that it is missing a mean to get the extradata
>>> directly,
>>> so matroska seems unhappy (I'd fix the matroska muxer since mp4 seems fine).
>>>
>>> Changelog | 1 +
>>> configure | 4 +
>>> doc/encoders.texi | 21 ++++
>>> doc/general.texi | 10 +-
>>> libavcodec/Makefile | 1 +
>>> libavcodec/allcodecs.c | 1 +
>>> libavcodec/libkvazaar.c | 288
>>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>> libavcodec/version.h | 2 +-
>>> 8 files changed, 326 insertions(+), 2 deletions(-)
>>> create mode 100644 libavcodec/libkvazaar.c
>>>
>>> +
>>> +AVCodec ff_libkvazaar_encoder = {
>>> + .name = "libkvazaar",
>>> + .long_name = NULL_IF_CONFIG_SMALL("libkvazaar H.265 / HEVC"),
>>> + .type = AVMEDIA_TYPE_VIDEO,
>>> + .id = AV_CODEC_ID_HEVC,
>>> + .capabilities = AV_CODEC_CAP_DELAY,
>>> + .pix_fmts = pix_fmts,
>>> +
>>> + .priv_class = &class,
>>> + .priv_data_size = sizeof(LibkvazaarContext),
>>> + .defaults = defaults,
>>> +
>>> + .init = libkvazaar_init,
>>> + .encode2 = libkvazaar_encode,
>>> + .close = libkvazaar_close,
>>> +
>>> + .caps_internal = FF_CODEC_CAP_INIT_THREADSAFE,
>> ^^^
>> can you (Arttu) make it FF_CODEC_CAP_INIT_CLEANUP too please?
>> every new encoder/decoder has it and it will simplify code a little
>> too, making it hard to introduce leaks in the future
>> after that it looks good to go imho
>>
>
> Did already, http://plaid.libav.org/patch/1866/
oh right, missed that, then push any time
--
Vittorio
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
