On Fri, Oct 23, 2015 at 3:31 PM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 23/10/15 15:29, Vittorio Giovara wrote: >> + // If mp3 packets have a non constant duration, they could need a parser >> + if (st->codec->codec_id == AV_CODEC_ID_MP3 && >> + sc->stts_count > 3 && >> + sc->stts_count * 10 > st->nb_frames && >> + sc->time_scale == st->codec->sample_rate) { >> + st->need_parsing = AVSTREAM_PARSE_FULL; >> + } > > We already set PARSE_FULL for another flavour, what breaks if we just > set it always? Heuristics are fragile.
There were a few objections to that during the discussion between wm4/nev/j45 that followed when analyzing the problem -- Vittorio _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel