On Mon, Oct 26, 2015 at 2:33 PM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 22/10/15 14:13, Vittorio Giovara wrote: >> Drop the need of setting -debug bugs since it's not a bug, and the >> message is already under a AV_LOG_DEBUG log level. Instead only print >> it when there is an actual string in it. >> --- >> libavcodec/h264_sei.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/h264_sei.c b/libavcodec/h264_sei.c >> index ddf1b6f..2b25840 100644 >> --- a/libavcodec/h264_sei.c >> +++ b/libavcodec/h264_sei.c >> @@ -229,7 +229,7 @@ static int decode_unregistered_user_data(H264Context *h, >> int size) >> if (e == 1 && build > 0) >> h->x264_build = build; >> >> - if (h->avctx->debug & FF_DEBUG_BUGS) > > Possibly it won't hurt performances. > >> + if (strlen(user_data + 16) > 0) > > user_data should be null terminated even if you just have 16 bytes, is > that really needed?
yes, it avoids printing empty strings ([h264 0x543434234] "") -- Vittorio _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel