On Wed, Dec 02, 2015 at 03:21:58PM +0100, Luca Barbato wrote:
> From: Kylie McClain <soma...@exherbo.org>
> 
> While pr is a valid POSIX.1 command, its usage in configure
> is a little borderline and is possible to replace it with
> printf.

While pr is a valid POSIX.1 command, it is not available on some systems
and can be replaced with printf without much fuss.

> --- a/configure
> +++ b/configure
> @@ -343,7 +343,11 @@ log(){
> 
>  log_file(){
>      log BEGIN $1
> -    pr -n -t $1 >> $logfile
> +    i=1
> +    while read line; do
> +        printf '%5s   %s\n' "${i}" "${line}"
> +        i=$(($i+1))
> +    done < $1 >> $logfile
>      log END $1
>  }

I still don't see the point of going to the trouble of printing line
numbers.  It's not worth even this little complexity to me.

Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to