On Sun, Dec 06, 2015 at 12:36:24PM +0000, Kieran Kunhya wrote: > Start templating functions for move to support 10-bit > Parts of this patch were written by Rostislav Pehlivanov > --- a/libavcodec/diracdec.c > +++ b/libavcodec/diracdec.c > @@ -507,6 +479,38 @@ static inline int coeff_unpack_golomb(GetBitContext *gb, > int qfactor, int qoffse > return coeff; > } > > +#define UNPACK_ARITH(n, type) \ > + static inline void coeff_unpack_arith_##n(DiracArith *c, int qfactor, > int qoffset, \ > + SubBand *b, type *buf, int x, > int y) \
I'd suggest dropping the indentation here, we do that for function macros in other places. > @@ -554,41 +558,69 @@ static inline void codeblock(DiracContext *s, SubBand > *b, > > +#define PARSE_VALUES(type, gb, ebits, buf1, buf2) \ This is used much later (~250 lines), I'd move it directly above its usage. > + *(type *)buf1 = coeff_unpack_golomb(gb, qfactor, qoffset); \ Ugh, pointer type punning :-/ Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
