On Mon, Jan 18, 2016 at 4:38 PM, Diego Biurrun <[email protected]> wrote: > --- > libavutil/x86/cpu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavutil/x86/cpu.c b/libavutil/x86/cpu.c > index 098ccf7..e7647dc 100644 > --- a/libavutil/x86/cpu.c > +++ b/libavutil/x86/cpu.c > @@ -200,8 +200,8 @@ int ff_get_cpu_flags_x86(void) > } > } > > - if (!strncmp(vendor.c, "GenuineIntel", 12)) { > - if (family == 6 && (model == 9 || model == 13 || model == 14)) { > + if (!strncmp(vendor.c, "GenuineIntel", 12) && family == 6) { > + if (model == 9 || model == 13 || model == 14) { > /* 6/9 (pentium-m "banias"), 6/13 (pentium-m "dothan"), and > * 6/14 (core1 "yonah") theoretically support sse2, but it's > * usually slower than mmx, so let's just pretend they don't. > @@ -219,7 +219,7 @@ int ff_get_cpu_flags_x86(void) > * on the Atom, but is generally faster on other processors > supporting > * SSSE3. This flag allows for selectively disabling certain SSSE3 > * functions on the Atom. */ > - if (family == 6 && model == 28) > + if (model == 28) > rval |= AV_CPU_FLAG_ATOM; > } >
I don't like this, if we ever get a future new family, this will need refactoring again instead of just adding another condition inside the Intel grouping. - Hendrik _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
