On Thu, Jan 21, 2016 at 12:23 PM, Diego Biurrun <di...@biurrun.de> wrote: > On Thu, Jan 21, 2016 at 11:38:20AM -0500, Vittorio Giovara wrote: >> On Thu, Jan 21, 2016 at 3:17 AM, Diego Biurrun <di...@biurrun.de> wrote: >> > On Wed, Jan 20, 2016 at 10:48:12AM -0500, Vittorio Giovara wrote: >> >> On Wed, Jan 20, 2016 at 5:10 AM, Diego Biurrun <di...@biurrun.de> wrote: >> >> > On Tue, Jan 19, 2016 at 07:45:25PM -0500, Vittorio Giovara wrote: >> >> >> --- a/libavcodec/eatqi.c >> >> >> +++ b/libavcodec/eatqi.c >> >> >> @@ -35,69 +35,177 @@ >> >> >> >> >> >> +/* Based off mpeg1_decode_block_intra from mpeg12dec.c */ >> >> > >> >> > s/Based off/Duplicated from/ >> >> >> >> it's not strictly duplicated as it has some simplifications, but ok >> > >> > Well, one "simplification" I noticed was mixing declarations and >> > statements, >> > so ... >> > >> >> > I don't see this as an improvement. >> >> >> >> why? >> > >> > Because it's code duplication, pure and simple. >> >> you can't be seriously comparing the mpegvideo detangling and a >> complete decoder deduplication (mpeg1) to the addition of a single >> relatively small function > > Yes, I can. You are turning an increase in size on the library level > for one obscure config (eatqi w/o mpeg1) to actual code duplication.
It's not completely clear why this build config is less or more important than the celp ones tbh. Regardless, I consider the addition for a 50 line function (which is going to optimized anyway, leading to a negligible size increase) a small price for having one less decoder depend on mpegvideo, one less file that needs to be recompiled whenever mpegvideo.h changes, and one less weird private function. Heck, I went ahead and measured this size increase before: 36784144 libavcodec/libavcodec.a after: 36775064 libavcodec/libavcodec.a so this patch created a SMALLER library, **with optimizations disabled**. -- Vittorio _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
