On Thu, Jan 28, 2016 at 6:19 PM, Vittorio Giovara
<vittorio.giov...@gmail.com> wrote:
> On Thu, Jan 28, 2016 at 5:00 AM, Diego Biurrun <di...@biurrun.de> wrote:
>> On Mon, Jan 25, 2016 at 12:56:12PM -0500, Vittorio Giovara wrote:
>>> --- a/libavcodec/eatqi.c
>>> +++ b/libavcodec/eatqi.c
>>> @@ -35,42 +35,51 @@
>>>
>>> -static int tqi_decode_mb(MpegEncContext *s, int16_t (*block)[64])
>>> +static int tqi_decode_mb(AVCodecContext *avctx, int16_t (*block)[64])
>>> {
>>> + TqiContext *t = avctx->priv_data;
>>> int n;
>>
>> This seems silly, just pass the TqiContext directly.
>
> Unless this is a strict request, I'd prefer to use AVCodecContext: I'd
> like that functions have the most consistent signature around, and, in
> general, in the future there might be need for it anyway.
>
>>> @@ -78,31 +87,35 @@ static int tqi_decode_mb(MpegEncContext *s, int16_t
>>> (*block)[64])
>>> return 0;
>>> }
>>>
>>> -static inline void tqi_idct_put(TqiContext *t, AVFrame *frame, int16_t
>>> (*block)[64])
>>> +static inline void tqi_idct_put(AVCodecContext *avctx, AVFrame *frame,
>>> + int16_t (*block)[64])
>>> {
>>> - MpegEncContext *s = &t->s;
>>> + TqiContext *t = avctx->priv_data;
>>
>> same
>
> this is needed by the avctx->flags below
>
>>> @@ -137,15 +149,15 @@ static int tqi_decode_frame(AVCodecContext *avctx,
>>> - s->last_dc[0] = s->last_dc[1] = s->last_dc[2] = 0;
>>> + memset(t->last_dc, 0, sizeof(t->last_dc));
>>
>> This is unrelated, please don't.
>
> sure, I had already removed this locally
> --
> Vittorio
ping on the set
--
Vittorio
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
