Quoting Hendrik Leppkes (2016-02-12 12:08:39) > On Fri, Feb 12, 2016 at 12:06 PM, Anton Khirnov <[email protected]> wrote: > > Quoting Mark Thompson (2016-02-12 12:02:50) > >> On 12/02/16 09:09, Anton Khirnov wrote: > >> > --- > >> > doc/APIchanges | 2 + > >> > libavutil/Makefile | 2 + > >> > libavutil/frame.c | 11 ++ > >> > libavutil/frame.h | 6 + > >> > libavutil/hwcontext.c | 397 > >> > +++++++++++++++++++++++++++++++++++++++++ > >> > libavutil/hwcontext.h | 328 ++++++++++++++++++++++++++++++++++ > >> > libavutil/hwcontext_internal.h | 89 +++++++++ > >> > 7 files changed, 835 insertions(+) > >> > create mode 100644 libavutil/hwcontext.c > >> > create mode 100644 libavutil/hwcontext.h > >> > create mode 100644 libavutil/hwcontext_internal.h > >> > ... > >> > >> The flags argument on these functions > >> > >> > +int av_hwframe_get_buffer(AVBufferRef *hwframe_ctx, AVFrame *frame, int > >> > flags); > >> > ... > >> > +int av_hwframe_transfer_data(AVFrame *dst, const AVFrame *src, int > >> > flags); > >> > ... > >> > +int av_hwframe_transfer_get_formats(AVBufferRef *hwframe_ctx, > >> > + enum AVHWFrameTransferDirection dir, > >> > + enum AVPixelFormat **formats, int > >> > flags); > >> > ... > >> > >> should be passed through to these functions? > >> > >> > + int (*frames_get_buffer)(AVHWFramesContext *ctx, > >> > AVFrame *frame); > >> > + int (*transfer_get_formats)(AVHWFramesContext *ctx, > >> > + enum > >> > AVHWFrameTransferDirection dir, > >> > + enum AVPixelFormat > >> > **formats); > >> > + int (*transfer_data_to)(AVHWFramesContext *ctx, > >> > AVFrame *dst, > >> > + const AVFrame *src); > >> > + int (*transfer_data_from)(AVHWFramesContext *ctx, > >> > AVFrame *dst, > >> > + const AVFrame *src); > >> > ... > >> > > > > Eventually yes, I just didn't see any point in doing that until we > > actually have some flags. > > > > Isnt changing the function signatures later a bit effort that can be avoided?
Work now versus work later. Doesn't really matter either way IMO, except I felt lazy. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
