On 24/02/16 09:22, Anton Khirnov wrote:
> Quoting Vittorio Giovara (2016-02-24 01:44:19)
>> A webserver omits the Content-Type or if mime-magic fails for unexpected
>> reasons, probing an image HTTP URL with query parameters will fail in
>> the extension match.
>>
>> So check the protocol used is http or https, and drop anything after
>> the first query parameter when evaluating an image URL.
>>
>> Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com>
>> ---
>> This fixes http://url/path.jpg?query=1 not being detected at all.
>> Video streams do not seem to need a similar solution, since they
>> use more ways to probe data before falling back to extensions.
>> I'm open to other solutions/ideas/suggestsions.
> 
> Sorry, this looks like an ugly ugly hack to me.
> 
> TheRightSolution(tm) is IMO:
> - adding a proper playlist API
> - replacing img2 with this API
> - adding per-image format demuxers with proper probing
> 
> I realize that's not exactly trivial to implement though.
> 

that also requires to implement correct probing of data...

I'm not against this since would take some long time to get that done.

lu
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to