On Tue, Mar 22, 2016 at 07:09:55PM +0100, wm4 wrote:
> --- a/avconv.c
> +++ b/avconv.c
> @@ -388,15 +388,25 @@ static void do_audio_out(AVFormatContext *s,
> OutputStream *ost,
> +
> + while (1) {
> + ret = avcodec_receive_packet(enc, &pkt);
> + if (ret == AVERROR(EAGAIN))
> + break;
> + if (ret < 0)
> + goto error;
>
> av_packet_rescale_ts(&pkt, enc->time_base, ost->st->time_base);
> output_packet(s, &pkt, ost);
> }
> +
> + return;
> +error:
> + av_log(NULL, AV_LOG_FATAL, "Audio encoding failed\n");
> + exit_program(1);
> }
Why not return instead of break and break instead of goto?
This reads somewhat odd to me.
possibly (more or less) same below
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
