Quoting Vittorio Giovara (2016-04-13 07:56:07) > On Wed, Apr 13, 2016 at 1:41 AM, Luca Barbato <[email protected]> wrote: > > Avoid the clang warning > > > > "warning: shifting a negative signed value is undefined" > > --- > > libavcodec/apedec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c > > index d33139b..8d84901 100644 > > --- a/libavcodec/apedec.c > > +++ b/libavcodec/apedec.c > > @@ -1305,7 +1305,7 @@ static void do_apply_filter(APEContext *ctx, int > > version, APEFilter *f, > > /* Update the adaption coefficients */ > > absres = FFABS(res); > > if (absres) > > - *f->adaptcoeffs = ((res & (-1<<31)) ^ (-1<<30)) >> > > + *f->adaptcoeffs = ((res & (~0UL<<31)) ^ (~0UL<<30)) >> > > (25 + (absres <= f->avg*3) + (absres <= > > f->avg*4/3)); > > else > > *f->adaptcoeffs = 0; > > -- > > 2.6.1 > > ok, feel free to add the proper spacing if you feel like it
It could really use some parentheses I think. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
