On Thu, Apr 14, 2016 at 12:49 PM, Luca Barbato <[email protected]> wrote: > On 14/04/16 12:47, wm4 wrote: >> On Thu, 14 Apr 2016 12:40:22 +0200 >> Diego Biurrun <[email protected]> wrote: >> >>> On Thu, Apr 14, 2016 at 12:21:17PM +0200, wm4 wrote: >>>> --- a/libavcodec/mmaldec.c >>>> +++ b/libavcodec/mmaldec.c >>>> @@ -166,7 +166,7 @@ static void ffmmal_stop_decoder(AVCodecContext *avctx) >>>> >>>> - assert(avpriv_atomic_get(&ctx->packets_buffered) == 0); >>>> + av_assert0(avpriv_atomic_get(&ctx->packets_buffered) == 0); >>> >>> .. because .. ? >> >> Because we use av_assert0() instead of assert() everywhere. Apparently >> the latter is normally disabled. The code wasn't even valid and never >> actually compiled, and I never noticed it myself. (michaelni didn't >> notice this either, so this patch broke compilation. It was fixed with >> patch 2/11, which I kept separate for authorship information.) > > Actually we should use the normal assert and have a fate instance to > enable them. > > force-enabling asserts for release builds is as bad as linking -lasan .
Checking things that are 100% code issues and impossible to be triggered by the media stream etc are perfectly fine to be checked at all times. - Hendrik _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
