On Tue, 19 Apr 2016, Luca Barbato wrote:
Module: libav
Branch: master
Commit: f3fdef108eb06b1e71b29152bf6822519e787efe
Author: Luca Barbato <[email protected]>
Committer: Luca Barbato <[email protected]>
Date: Tue Apr 12 22:14:26 2016 +0200
ape: Avoid undefined behaviour
Avoid the clang warning
"warning: shifting a negative signed value is undefined"
---
libavcodec/apedec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c
index d33139b..85d26ae 100644
--- a/libavcodec/apedec.c
+++ b/libavcodec/apedec.c
@@ -1305,7 +1305,7 @@ static void do_apply_filter(APEContext *ctx, int version,
APEFilter *f,
/* Update the adaption coefficients */
absres = FFABS(res);
if (absres)
- *f->adaptcoeffs = ((res & (-1<<31)) ^ (-1<<30)) >>
+ *f->adaptcoeffs = ((res & ((~0UL) << 31)) ^ ((~0UL) << 30)) >>
(25 + (absres <= f->avg*3) + (absres <=
f->avg*4/3));
else
*f->adaptcoeffs = 0;
This breaks lossless-monkeysaudio-399 in 32 bit configurations.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
