Re: [libav-devel] [PATCH 3/7] Add the new bitstream reader.

[Alexandra Hájková]

>> +/**
>> + * Return one bit from the buffer.
>> + */
>> +static inline unsigned int bitstream_read_bit(BitstreamContext *s)
>> +{
>> +    if (av_unlikely(!s->bits_left))
>> +        refill_64(s);
>> +
>> +    return (uint8_t)get_val(s, 1);
>
> I'd use !!get_val(s, 1)
>
I think the cast is not really needed in this place, I'd change this
part to just return get_val
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel