On Wed, Jun 15, 2016 at 5:31 PM, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Wed, Jun 15, 2016 at 11:06 PM, Vittorio Giovara > <vittorio.giov...@gmail.com> wrote: >> On Wed, Jun 15, 2016 at 3:49 PM, Hendrik Leppkes <h.lepp...@gmail.com> wrote: >>> On Wed, Jun 15, 2016 at 9:08 PM, Vittorio Giovara >>> <vittorio.giov...@gmail.com> wrote: >>>> On Wed, Jun 15, 2016 at 3:00 PM, Hendrik Leppkes <h.lepp...@gmail.com> >>>> wrote: >>>>> On Wed, Jun 15, 2016 at 8:53 PM, Luca Barbato <lu_z...@gentoo.org> wrote: >>>>>> On 15/06/16 20:25, Vittorio Giovara wrote: >>>>>>> This allows to directly use av_color_*_name() return value as >>>>>>> command line parameters for the encoder. >>>>>>> --- >>>>>>> libavutil/pixdesc.c | 8 ++++---- >>>>>>> libavutil/version.h | 2 +- >>>>>>> 2 files changed, 5 insertions(+), 5 deletions(-) >>>>>> >>>>>> I consider the previous names bugs. >>>>>> >>>>> >>>>> Having the string names mismatch the symbol name seems like the real bug >>>>> to me. >>>> >>>> The alternative is to replace/deprecate symbol names, I'm not sure >>>> whether a symbol name bikeshed warrants an API break (which would be >>>> difficult to track since there cannot be guards for enum names). >>> >>> The alternative is to keep it as-is, imho. >> >> That defies the whole existence of this API and the rationale behind this >> set. > > Your whole set lacks reason, it looks like arbitrary renames to me > because you like them better.
I guess you mean that you don't see the reason, not that it lacks it. The API I wrote has been intended for that use since day one, to be compatible with x264 settings: a very common usecase is to use properties from probe json (which is filled by these functions) and use them to call x264 from command line, without having to introduce a conversion table from day one. Unfortunately this got lost during the addition of new elements to the enum, and with the adoption of different names from x264. Now that they have been settled though, it seems wise to me to restore this functionality. Also only very recent and very new elements are affected, which are hardly available to distros probably. Finally with the addition of 4/5 we will be able to use these names when calling the conversion tool too, so we will finally be compatible with ourselves. -- Vittorio _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
