On Fri, Jun 17, 2016 at 1:45 PM, Diego Biurrun <di...@biurrun.de> wrote:
> On Fri, Jun 17, 2016 at 12:10:31PM -0400, Vittorio Giovara wrote:
>> On Fri, Jun 17, 2016 at 10:20 AM, Diego Biurrun <di...@biurrun.de> wrote:
>> > On Mon, Jun 06, 2016 at 12:31:56PM -0400, Vittorio Giovara wrote:
>> >> --- /dev/null
>> >> +++ b/libavcodec/magicyuv.c
>> >> @@ -0,0 +1,469 @@
>> >> +
>> >> +static int magy_decode_slice(AVCodecContext *avctx, void *tdata,
>> >> + int j, int threadnr)
>> >> +{
>> >> + int fake_stride = p->linesize[i] * (1 + interlaced);
>> >> + int stride = p->linesize[i];
>> >
>> > Strides should be ptrdiff_t; not sure here when frame.linesize is int
>> > already.
>>
>> I changed it anyway.
>>
>> >> + for (i = 0; i < s->planes; i++) {
>> >> + av_fast_malloc(&s->slices[i], (unsigned *)&s->slices_size[i],
>> >> s->nb_slices * sizeof(Slice));
>> >
>> > Do you need the cast?
>>
>> yeah, av_fast_malloc needs unsigned int * there, and this element type
>> was changed to size_t in the previous iteration.
>
> Not sure if it's worth it then. av_fast_*alloc should really use size_t
> and not unsigned int, *sigh* ..
I'll revert and use unsigned int until someone does not break the api ;)
Also I have to change slice_height to int (or is ssize_t better?)
because it's later used for signed operations and breaks on 32bits
otherwise.
--
Vittorio
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
