On Fri, Jun 24, 2016 at 10:00:31PM +0300, Martin Storsjö wrote: > On Fri, 24 Jun 2016, Diego Biurrun wrote: > > On Fri, Jun 24, 2016 at 01:07:08AM +0300, Martin Storsjö wrote: > >> --- /dev/null > >> +++ b/libavcodec/libopenh264.h > >> @@ -0,0 +1,39 @@ > >> + > >> +#ifndef AVCODEC_LIBOPENH264_H > >> +#define AVCODEC_LIBOPENH264_H > >> + > >> +#endif > > > > missing #endif comment > > ... and if I fix that? > > A "LGTM otherwise" or similar (or an explicit note saying the opposite), > for trivial review comments like these, would be useful, to save one extra > round of resending and review...
That nit just caught my eye, so I mentioned it quickly. I have mixed feelings about this beast, so I'm abstaining from the decision of accepting it or not. I also haven't looked at it in enough depth to say whether it's OK or not. Hence my silence on the patch in general. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
