On Mon, Jun 27, 2016 at 6:38 PM, Diego Biurrun <di...@biurrun.de> wrote: > On Mon, Jun 27, 2016 at 11:51:50AM -0400, Vittorio Giovara wrote: >> On Mon, Jun 27, 2016 at 11:05 AM, Hendrik Leppkes <h.lepp...@gmail.com> >> wrote: >> > On Mon, Jun 27, 2016 at 4:22 PM, Diego Biurrun <di...@biurrun.de> wrote: >> >> It is also used by the Dirac parsing code. >> >> --- >> >> configure | 15 ++++++++------- >> >> libavcodec/Makefile | 1 + >> >> libavcodec/mpeg12data.c | 20 -------------------- >> >> libavcodec/mpeg12framerate.c | 39 +++++++++++++++++++++++++++++++++++++++ >> >> 4 files changed, 48 insertions(+), 27 deletions(-) >> >> create mode 100644 libavcodec/mpeg12framerate.c >> >> >> >> --- a/configure >> >> +++ b/configure >> >> @@ -1705,6 +1705,7 @@ CONFIG_EXTRA=" >> >> me_cmp >> >> mpeg_er >> >> + mpeg12framerate >> >> mpegaudio >> >> mpegaudiodsp >> > >> > Do we really need config entries for 50 line data table files, instead >> > of making the relevant parts in the Makefile reference those files? >> > Seems like a lot of noise to create features for single-file >> > "features" that are just shared tables. >> >> I'd tend to agree, moving the tables to a separate file is okay, but >> I'd just add the .o to the Makefile rather than adding an element to >> configure. > > Quoting you from another mail: > > what I mean is that just by looking at configure you immediately know > which codecs depends on which component, instead of looking at both > configure and Makefile > > You're directly contradicting yourself, please make up your mind ;)
I don't consider tables as components, but just data, and data can stay in a Makefile imho -- Vittorio _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
