Quoting Anton Khirnov (2016-07-29 16:26:36)
> Quoting James Almer (2016-07-29 16:20:48)
> > On 7/29/2016 8:52 AM, Anton Khirnov wrote:
> > > Adapted from the code by Rémi Denis-Courmont from VLC
> > > ---
> > >  compat/atomics/gcc/stdatomic.h | 175 
> > > +++++++++++++++++++++++++++++++++++++++++
> > >  configure                      |   6 ++
> > >  2 files changed, 181 insertions(+)
> > >  create mode 100644 compat/atomics/gcc/stdatomic.h
> > > 
> > 
> > Wouldn't it be better to use the new atomic builtins (gcc 4.7 and
> > newer) instead of the deprecated __sync ones? Unlike the latter 
> > they also support the memory order argument, so it's a much better
> > fit for these wrappers.
> > 
> > https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html
> 
> What would be the point? gcc 4.7 supports c11, so this fallback won't be
> used there.

Ok, now I've tested it and it doesn't have stdatomic.h
Still, I wouldn't bother, since only a few versions will have those new
atomics and not have stdatomic.h

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to