On Fri, Aug 26, 2016 at 07:36:29AM -0500, Burt P wrote:
> --- /dev/null
> +++ b/libavfilter/af_hdcd.c
> @@ -0,0 +1,199 @@
> +
> +#include <hdcd/hdcd_simple.h>
Is there a hdcd_complicated.h header as well?
> +typedef struct HDCDContext {
> + const AVClass *class;
> +
> + hdcd_simple *shdcd;
same question, sort of ..
> +static av_cold void uninit(AVFilterContext *ctx)
> +{
> + HDCDContext *s = ctx->priv;
> + char detect_str[256] = "";
> +
> + /* log the HDCD decode information */
> + hdcd_detect_str(s->shdcd, detect_str, sizeof(detect_str));
> + av_log(ctx, AV_LOG_INFO, "%s\n", detect_str);
I wonder if verbose level logging is enough here, dunno.
> +static void af_hdcd_log(const void *priv, const char *fmt, va_list args)
> +{
> + av_vlog((AVFilterContext *)priv, AV_LOG_VERBOSE, fmt, args);
Why do you cast to AVFilterContext* here? I would guess that all you
need is to get rid of the const, if at all.
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
