On Tue, Sep 20, 2016 at 11:09:51PM +0100, Mark Thompson wrote:
> On 20/09/16 19:36, Diego Biurrun wrote:
> Aside:
> 
> Seeing a lot of little functions like (picking a random one):
> 
> > -static void spatial_compensation_3(uint8_t *src, uint8_t *dst, int 
> > linesize)
> > +static void spatial_compensation_3(uint8_t *src, uint8_t *dst, ptrdiff_t 
> > stride)
> >  {
> >      int x, y;
> >  
> >      for (y = 0; y < 8; y++) {
> >          for (x = 0; x < 8; x++)
> >              dst[x] = src[area4 + ((y + 1) >> 1) + x];
> > -        dst += linesize;
> > +        dst += stride;
> >      }
> >  }
> 
> makes me wonder how much faster the C code would be if we just added the 
> right type qualifiers to all the pointers.

Are you trying to troll me into my next refactoring project? :)

Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to