On 2016-10-20 21:35:45 +0200, Diego Biurrun wrote: > On Sun, Oct 16, 2016 at 08:10:52PM +0200, Janne Grunau wrote: > > --- > > libavfilter/x86/vf_yadif_init.c | 21 ++- > > libavfilter/x86/Makefile | 2 +- > > libavfilter/x86/yadif-10.asm | 284 > > ++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 305 insertions(+), 2 deletions(-) > > create mode 100644 libavfilter/x86/yadif-10.asm > > This should be called vf_yadif-10.asm IMO.
I'd rather not rename the files to avoid making merging any harder than it already is. > > --- /dev/null > > +++ b/libavfilter/x86/yadif-10.asm > > @@ -0,0 +1,284 @@ > > +;***************************************************************************** > > +;* x86-optimized functions for yadif filter > > Again, this could mention the bit depth. > > > +SECTION_RODATA > > + > > +pw_1: times 8 dw 1 > > The constant is duplicated. I can send a patch to deduplicate it. > > +SECTION .text > > + > > +%macro PABS 2 > > +%if cpuflag(ssse3) > > + pabsw %1, %1 > > +%else > > + pxor %2, %2 > > + pcmpgtw %2, %1 > > + pxor %1, %2 > > + psubw %1, %2 > > +%endif > > +%endmacro > > + > > +%macro PMAXUW 2 > > +%if cpuflag(sse4) > > + pmaxuw %1, %2 > > +%else > > + psubusw %1, %2 > > + paddusw %1, %2 > > +%endif > > +%endmacro > > These are duplicated with the 16-bit patch. PABS is moved later to x86macros, I'll send a separate patch to move PMAXUW Janne _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
