On 10/30/2016 4:48 PM, Hendrik Leppkes wrote: > On Sun, Oct 30, 2016 at 8:45 PM, James Almer <jamr...@gmail.com> wrote: >> On 10/30/2016 4:20 PM, Hendrik Leppkes wrote: >>> On Sun, Oct 30, 2016 at 8:08 PM, James Almer <jamr...@gmail.com> wrote: >>>> The spec says it should be void. >>>> >>>> Signed-off-by: James Almer <jamr...@gmail.com> >>>> --- >>>> libavformat/matroskaenc.c | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c >>>> index aa9d381..c3a9702 100644 >>>> --- a/libavformat/matroskaenc.c >>>> +++ b/libavformat/matroskaenc.c >>>> @@ -584,6 +584,8 @@ static int >>>> mkv_write_native_codecprivate(AVFormatContext *s, >>>> avio_write(dyn_cp, par->extradata + 12, >>>> par->extradata_size - 12); >>>> break; >>>> + case AV_CODEC_ID_AAC: >>>> + break; >>>> default: >>>> if (par->extradata_size) >>>> avio_write(dyn_cp, par->extradata, par->extradata_size); >>>> -- >>>> 2.10.1 >>> >>> Thats the old spec, the new spec wants the 2-5 byte configuration >>> record with plain A_AAC (no weird sub-entries for profiles etc) >> >> Where does it says that? I checked >> https://matroska.org/technical/specs/codecid/index.html >> and >> https://github.com/Matroska-Org/matroska-specification/blob/gh-pages/codec_specs.md >> and for every possible AAC CodecID it says "The private data is void" in >> both. >> >> Neither mention anything about plain A_AAC id, for that matter. >> > > Its listed in here: > http://haali.su/mkv/codecs.pdf > > Codec IDs in matroska are the formats biggest mess right now, there is > no proper central registry, and the spec website links to the PDF as > "an additional resource".
Lovely. Anyway, consider this patch dropped then. Thanks. _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
