On Thu, Nov 3, 2016 at 3:42 PM, Anton Khirnov <an...@khirnov.net> wrote:
> Quoting Diego Biurrun (2016-11-03 18:32:35)
>> avconv_opt.c:188:19: warning: comparison of unsigned expression < 0 is
>> always false [-Wtype-limits]
>> ---
>> avconv_opt.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/avconv_opt.c b/avconv_opt.c
>> index 1064cf4..a3fd3dd 100644
>> --- a/avconv_opt.c
>> +++ b/avconv_opt.c
>> @@ -187,12 +187,11 @@ static double parse_frame_aspect_ratio(const char *arg)
>>
>> static int show_hwaccels(void *optctx, const char *opt, const char *arg)
>> {
>> - int i;
>> + int i = 0;
>>
>> printf("Supported hardware acceleration:\n");
>> - for (i = 0; i < FF_ARRAY_ELEMS(hwaccels) - 1; i++) {
>> + while (hwaccels[i++].name)
>> printf("%s\n", hwaccels[i].name);
>> - }
>> printf("\n");
>> return 0;
>> }
>> --
>> 2.1.4
>
> I am against uglifying perfectly valid code just to please some
> compilers.
+1, also the new codec is IMO harder to read
--
Vittorio
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
